Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Load locales in pre-commit if necessary #1599

Merged
merged 1 commit into from
Aug 2, 2022
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Aug 1, 2022

Fixes

Fixes #1598 by @obulat

Description

This PR adds a check for src/locales/ar.json existence. If it doesn't exist, pre-commit runs pnpm i18n to load translations.

Testing Instructions

Remove src/locales/ar.json if you have it. Create a new branch based on this PR's branch, add any change and run git commit -m "Test commit". You should see a message that i18n scripts load locale files, and the commit should be successful.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@github-actions
Copy link

github-actions bot commented Aug 1, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/_preview/1599
Tailwind: https://wordpress.github.io/openverse-frontend/_preview/1599/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Aug 1, 2022
@obulat obulat marked this pull request as ready for review August 1, 2022 16:01
@obulat obulat requested a review from a team as a code owner August 1, 2022 16:01
@obulat obulat requested review from krysal and dhruvkb August 1, 2022 16:01
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working great! Is there no problem in that it's saving all the translations when only a few are needed (I think so)?

Successfully saved 182 translations.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@obulat
Copy link
Contributor Author

obulat commented Aug 2, 2022

It's working great! Is there no problem in that it's saving all the translations when only a few are needed (I think so)?

Locally, all locales are usually saved when you run pnpm dev or pnpm build anyways. So, this change is only necessary if you have never run pnpm dev or pnpm build before, and want to git commit.

@obulat obulat merged commit da03b03 into main Aug 2, 2022
@obulat obulat deleted the fix/load_locales_for_precommit branch August 2, 2022 05:38
github-actions bot pushed a commit that referenced this pull request Aug 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pre-commit fails if locale files are not loaded
4 participants