Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add line reference comments to the POT file #159

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Aug 24, 2021

Description

This PR adds the reference links to where the strings are located in the code to the POT file.

# hero.title 
#: https://github.com/WordPress/openverse-frontend/blob/main/src/components/HeroSection.vue#L6
msgctxt "hero.title"
msgid "Search for content to reuse"
msgstr ""

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from a team as a code owner August 24, 2021 16:37
@obulat obulat requested review from zackkrida and sarayourfriend and removed request for a team August 24, 2021 16:37
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is so cool!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤩 Works perfectly. The new .pot file looks correct, and there are no issues when a file reference can't be found for a string.

@obulat obulat merged commit 6e88ce7 into custom-pot-script Aug 24, 2021
@obulat obulat deleted the add_code_line_refs branch August 24, 2021 17:31
@zackkrida zackkrida added the 🧰 goal: internal improvement Improvement that benefits maintainers, not users label Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🧰 goal: internal improvement Improvement that benefits maintainers, not users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants