-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1550 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Okay, there was a post-run issue with the setup-node-env that seems to just be an intermittent failure. But the rest of the workflow ran successfully and you can see the commit it made here: 04c5da3 Here is the run in question: https://github.com/WordPress/openverse-frontend/runs/7124031759?check_suite_focus=true I'm removing the testing code now and then this will be ready for review. Whoever is second to approve it feel free to merge it at your leisure if it is after EOD for me. |
Because the `translations` branch has nothing in it except for the README and the openverse.pot file, the post-run actions for our `setup-node-env` action is unable to run (it won't be able to find the files it needs). Therefore, we need to recheckout the `main` branch. I've gone ahead and updated the initial checkout to also be explicit about the branch it checks out so that the intention here is clear.
Actually, I realized why the cleanup failed. Details in the message attached to this commit: 1146aa4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, multiple scoped checkouts should be faster than my suggestion. This looks right 🤞
Fixes
Follow up to #1535 @sarayourfriend
Description
As @zackkrida pointed out in the original #1051 issue, the workflow is not working due to not being able to checkout the translations branch. I'm trying to fix that here.
Testing Instructions
Checkout the workflow runs and confirm that it works in this PR.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin