Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix PO generation workflow #1550

Merged
merged 3 commits into from
Jul 1, 2022
Merged

Fix PO generation workflow #1550

merged 3 commits into from
Jul 1, 2022

Conversation

sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented Jun 30, 2022

Fixes

Follow up to #1535 @sarayourfriend

Description

As @zackkrida pointed out in the original #1051 issue, the workflow is not working due to not being able to checkout the translations branch. I'm trying to fix that here.

Testing Instructions

Checkout the workflow runs and confirm that it works in this PR.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels Jun 30, 2022
@sarayourfriend sarayourfriend requested a review from a team as a code owner June 30, 2022 02:55
@sarayourfriend sarayourfriend requested review from krysal and dhruvkb June 30, 2022 02:55
@github-actions
Copy link

github-actions bot commented Jun 30, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/1550
Tailwind: https://wordpress.github.io/openverse-frontend/1550/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@sarayourfriend
Copy link
Contributor Author

sarayourfriend commented Jun 30, 2022

Okay, there was a post-run issue with the setup-node-env that seems to just be an intermittent failure. But the rest of the workflow ran successfully and you can see the commit it made here: 04c5da3

Here is the run in question: https://github.com/WordPress/openverse-frontend/runs/7124031759?check_suite_focus=true

I'm removing the testing code now and then this will be ready for review. Whoever is second to approve it feel free to merge it at your leisure if it is after EOD for me.

Because the `translations` branch has nothing in it except for the
README and the openverse.pot file, the post-run actions for our
`setup-node-env` action is unable to run (it won't be able to find the
files it needs). Therefore, we need to recheckout the `main` branch.
I've gone ahead and updated the initial checkout to also be explicit
about the branch it checks out so that the intention here is clear.
@sarayourfriend
Copy link
Contributor Author

Actually, I realized why the cleanup failed. Details in the message attached to this commit: 1146aa4

@sarayourfriend sarayourfriend changed the title Checkout using checkout action Fix PO generation workflow Jun 30, 2022
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, multiple scoped checkouts should be faster than my suggestion. This looks right 🤞

@sarayourfriend sarayourfriend merged commit f99feec into main Jul 1, 2022
@sarayourfriend sarayourfriend deleted the fix/po-generation-workflow branch July 1, 2022 01:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants