Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add audio duration filter clarifications as strings #1547

Merged
merged 10 commits into from
Jul 5, 2022
Merged

Conversation

obulat
Copy link
Contributor

@obulat obulat commented Jun 28, 2022

Fixes

Fixes #1538 by @obulat

Description

I've added the clarification as text so this PR does not change anything in the code. But if we want to style them differently, I would need to separate the names from the clarification texts. Please, let me think what you think.

Audio length filters with clarification

Testing Instructions

Run the app and open the Audio search page filters.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@obulat obulat requested a review from fcoveram June 28, 2022 09:43
@github-actions
Copy link

github-actions bot commented Jun 28, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/1547
Tailwind: https://wordpress.github.io/openverse-frontend/1547/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

@openverse-bot openverse-bot added ✨ goal: improvement Improvement to an existing user-facing feature 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon labels Jun 28, 2022
@obulat obulat marked this pull request as ready for review June 28, 2022 09:52
@obulat obulat requested a review from a team as a code owner June 28, 2022 09:52
@obulat obulat requested review from krysal and dhruvkb June 28, 2022 09:52
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
obulat and others added 2 commits June 29, 2022 11:14
Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: Zack Krida <zackkrida@pm.me>
@fcoveram
Copy link

It looks simple and works great.

My only suggestion is to eliminate the classification (shortest, short, medium, and long) and keep the time length, as SoundCloud does.

CleanShot 2022-06-29 at 09 53 51@2x

On the other hand, I wonder if it is fine using abbreviations such as min for meeting i18n requirements. If so, then I suggest using sec for seconds and adding a whitespace character between the number and the word. The outcome would be:

< 30 sec
30 sec-2 min
2-10 min
> 10 min

@zackkrida
Copy link
Member

I decided to ask about this in the #polyglots channel. We can see if they have any suggestions:

https://wordpress.slack.com/archives/C02RP50LK/p1656514587496599

@obulat
Copy link
Contributor Author

obulat commented Jun 30, 2022

My only suggestion is to eliminate the classification (shortest, short, medium, and long) and keep the time length, as SoundCloud does.

That is actually much simpler and easier to understand ! :)

Thank you for asking in the polyglot channel, @zackkrida ! I think that these translations should be simple because they are hard-coded, and the values for seconds or minutes in strings like '30 sec - 1 min' do not change. If they did, we would have to go the pluralization route, which usually requires more effort. I'm going to go look at the channel :)

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is done. Nice!

@obulat
Copy link
Contributor Author

obulat commented Jun 30, 2022

Updated screenshot:

Screen Shot 2022-06-30 at 5 31 54 PM

@obulat obulat requested a review from zackkrida June 30, 2022 14:34
src/locales/en.json Outdated Show resolved Hide resolved
Co-authored-by: Zack Krida <zackkrida@pm.me>
@obulat obulat requested a review from zackkrida June 30, 2022 18:49
src/locales/en.json Outdated Show resolved Hide resolved
src/locales/en.json Outdated Show resolved Hide resolved
@fcoveram fcoveram requested review from zackkrida and fcoveram July 1, 2022 13:40
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@fcoveram fcoveram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great ✨

# Conflicts:
#	src/locales/po-files/openverse.pot
@github-actions
Copy link

github-actions bot commented Jul 1, 2022

Playwright Failure Test Results

It looks like some of the Playwright tests failed. You can download the Playwright trace
output for both Storybook and Nuxt Playwright tests that have failed at the bottom of this
page, under the "Artifacts" section:

https://github.com/WordPress/openverse-frontend/actions/runs/2597398342

Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging

@krysal krysal merged commit 7c5a3eb into main Jul 5, 2022
@krysal krysal deleted the add/duration_filter branch July 5, 2022 15:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software ✨ goal: improvement Improvement to an existing user-facing feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add clarification for length filters
5 participants