-
Notifications
You must be signed in to change notification settings - Fork 63
Add audio duration filter clarifications as strings #1547
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1547 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Co-authored-by: Zack Krida <zackkrida@pm.me>
Co-authored-by: Zack Krida <zackkrida@pm.me>
It looks simple and works great. My only suggestion is to eliminate the classification (shortest, short, medium, and long) and keep the time length, as SoundCloud does. On the other hand, I wonder if it is fine using abbreviations such as
|
I decided to ask about this in the #polyglots channel. We can see if they have any suggestions: https://wordpress.slack.com/archives/C02RP50LK/p1656514587496599 |
That is actually much simpler and easier to understand ! :) Thank you for asking in the polyglot channel, @zackkrida ! I think that these translations should be simple because they are hard-coded, and the values for seconds or minutes in strings like '30 sec - 1 min' do not change. If they did, we would have to go the pluralization route, which usually requires more effort. I'm going to go look at the channel :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is done. Nice!
Co-authored-by: Zack Krida <zackkrida@pm.me>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great ✨
# Conflicts: # src/locales/po-files/openverse.pot
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/2597398342 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
Fixes
Fixes #1538 by @obulat
Description
I've added the clarification as text so this PR does not change anything in the code. But if we want to style them differently, I would need to separate the names from the clarification texts. Please, let me think what you think.
Testing Instructions
Run the app and open the Audio search page filters.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin