Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Implement drag-to-seek #154

Merged
merged 6 commits into from
Aug 24, 2021
Merged

Implement drag-to-seek #154

merged 6 commits into from
Aug 24, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 24, 2021

Fixes

Fixes #142 by @sarayourfriend

Description

This PR

  • implements drag-to-seek functionality
  • switches to composition API to better organise the code
  • some minor cleanups, renames and refactors

Technical details

Vue i18n seems to not work very well with the composition API so usages of t in the <script> sections requires using the old options API syntax.

Tests

Screenshots

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are welcome refactors along with the dragging functionality. great!

@dhruvkb dhruvkb marked this pull request as ready for review August 24, 2021 14:25
@dhruvkb dhruvkb requested a review from a team as a code owner August 24, 2021 14:25
@dhruvkb dhruvkb requested review from krysal and sarayourfriend and removed request for a team August 24, 2021 14:25
Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally and it works great! Super awesome work! 🤩

@dhruvkb dhruvkb merged commit 31f32f0 into audio Aug 24, 2021
@dhruvkb dhruvkb deleted the drag_to_seek branch August 24, 2021 16:13
@dhruvkb dhruvkb linked an issue Aug 30, 2021 that may be closed by this pull request
1 task
@zackkrida zackkrida added the ✨ goal: improvement Improvement to an existing user-facing feature label Sep 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
✨ goal: improvement Improvement to an existing user-facing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Waveform drag to seek
3 participants