This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Replace {} placeholders with ### and escape quotes in strings in POT file #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
requested review from
zackkrida and
sarayourfriend
and removed request for
a team
obulat
changed the title
9 tasks
zackkrida
approved these changes
Aug 24, 2021
Comment on lines
+4
to
+13
| /* | ||
| * white-space | ||
| # translator-comments | ||
| #. extracted-comments | ||
| #: reference… | ||
| #, flag… | ||
| #| msgid previous-untranslated-string | ||
| msgid untranslated-string | ||
| msgstr translated-string | ||
| */ |
There was a problem hiding this comment.
Thank you for adding this, very helpful!
zackkrida
added
the
🧰 goal: internal improvement
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some strings in the translation file have double quotes in them. These are illegal in PO files without escaping. This PR escapes the double quotes in the 'pot' conversion script.