This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Organize playwright test tapes into folders #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1513 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: +1 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
obulat
force-pushed
the
organize_playwright_tests
branch
from
b0abff3 to
398d132
Compare
|
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/2467659309 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
obulat
changed the title
obulat
added
🟨 priority: medium
|
Never mind! I was accidentally looking only at a single random commit in the middle of this PR's history. I have no idea how GitHub decides whether to show me the full PR or just one commit. So bizarre! |
sarayourfriend
approved these changes
Jun 9, 2022
There was a problem hiding this comment.
LGTM! Much more organized.
Shall we add a README describing the folders and when to put things in the components vs the page tests? Additionally, when to choose to test a component on an actual page instead of writing a story for it and writing the e2e tests for it there.
|
Playwright Failure Test Results It looks like some of the Playwright tests failed. You can download the Playwright trace https://github.com/WordPress/openverse-frontend/actions/runs/2475350050 Read more about how to use this artifact here: https://github.com/WordPress/openverse-frontend/blob/main/test/playwright/README.md#debugging |
obulat
added
🟧 priority: high
dhruvkb
approved these changes
Jun 14, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to #797 by @sarayourfriend
Not strictly related, but adding this change would greatly simplify navigating the tapes while working on #797.
Marked as high because further work on testing should be based on this change.
Description
This PR moves all the tapes used in the Playwright tests into folders based on the request type:
detail,search,relatedandthumb, and on the media type inside those folders. This means we can hide the folder and don't have to scroll as much in the IDE file list.It also splits the visual regression tests into two folders: pages and components.
Testing Instructions
Passing CI should be enough.
The main change is in
test/proxy.jsfile.Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin