This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add a fallback for broken provider image #1493
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟨 priority: medium
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1493 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
|
Size Change: -751 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
I wonder if we could accomplish this using just CSS: https://stackoverflow.com/a/33959259
It may even have the extra benefit of preventing people from trying to download the image from Openverse instead of visiting the provider directly for it (though I can't decide if that's a dark pattern for us to implement).
I'm fine with the JS solution you've taken here but if we can do it without JavaScript that would be great 🙂
|
Based on the medium urgency of this PR, the following reviewers are being This reminder is being automatically generated due to the urgency configuration. @obulat, if this PR is not ready for a review, please draft it to prevent reviewers |
dhruvkb
approved these changes
Jun 28, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to WordPress/openverse#615 by @obulat
Description
We are currently requesting provider media during the Playwright tests to render single image detail and audio detail pages. This creates flaky and slow tests. Until we create a solution to proxy those requests, we can block or mock the provider media requests entirely.
Blocking the provider media requests would result in a broken image on the image detail page during Playwright tests. To prevent this, this PR adds the logic to replace the provider image with the thumbnail on load error. Since the thumbnails have the same dimensions as the provider image they allow us to test that the different dimensions are treated correctly).
Testing Instructions
Search for 'birds', and open the first image result. Block the requests to 'Flickr', and reload the image.
Visually, the page should be the same as before, but it should be using the 'thumbnail' from our API as the main image.
Also, try blocking the main thumbnail image. You should see the error image placeholder.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin