This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Use defineComponent, add prop types and emit types
#1480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
added
🟩 priority: low
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1480 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
|
Size Change: -409 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
obulat
force-pushed
the
ts_more_components
branch
from
a4b3068 to
7b50f23
Compare
I've added the files that pass the types check. |
obulat
commented
Jun 21, 2022
| @@ -13,43 +16,50 @@ | |||
| /> | |||
| <LoadingIcon v-show="fetchState.isFetching" /> | |||
| </div> | |||
| <p v-show="!!fetchState.isError"> | |||
| <p v-show="!!fetchState.fetchingError"> | |||
There was a problem hiding this comment.
Apparently, this was using the incorrect parameter name here, so it wasn't working correctly. Nice that TS can help us catch such problems.
# Conflicts: # src/locales/po-files/openverse.pot
obulat
commented
Jun 27, 2022
| "src/components/VContentLink/VContentLink.vue", | ||
| "src/components/VCopyButton.vue", | ||
| "src/components/VSketchFabViewer.vue", | ||
| "src/components/VAudioThumbnail/**.vue", |
There was a problem hiding this comment.
I've ordered the list: single components outside of directories come first, then paths with ** in them, then components in sub-directories, and finally pages.
dhruvkb
approved these changes
Jun 28, 2022
There was a problem hiding this comment.
I really wish there was a better way than listing each component individually in the tsconfig.json file. This is a good PR. I only have one minor nit and a question:
- When we remove the validator from the props, there would be no runtime warnings for invalid values because all the TS will be transpiled to JS, so shouldn't we keep them?
obulat
commented
Jun 28, 2022
We have discussed with @sarayourfriend before that we want to remove the validators. I don't quite remember what the decision was regarding the runtime warnings and why we might not need them. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to Typescriptification milestone
Description
This PR is extracted from #1405 to make it easier to review.
It adds
defineComponent, sets the language tots, documentsemits, and replaces JSDoc comments with TS annotations for more components. It only changes the files that can be added totsconfig(i.e., don't have popup ariakit dependencies)Testing Instructions
Passing CI should be enough.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin