-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
Sets the min-height to the ClientOnly image row. Sets the searchbar height to fixed value, and use `h-full` in child components.
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1470 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Size Change: +41 B (0%) Total Size: 1.44 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. The one pixel difference in the searchbar height seems like a rounder, design-friendlier number, so it's a welcomed change 😆
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's very difficult to spot any changes in the snapshots, I assume that's a good thing. Appreciate the use of h-full
instead of the hardcoded magic numbers.
Fixes
Fixes #1298 by @obulat
Description
This PR fixes the layout jumping on the mobile page:
h-full
in child components.Testing Instructions
Run the app, go to the homepage
localhost:8443
. The layout should not jump. Try different screen widths.Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin