Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Remove ternary from ghcr.yml #1452

Merged
merged 1 commit into from
May 17, 2022
Merged

Remove ternary from ghcr.yml #1452

merged 1 commit into from
May 17, 2022

Conversation

sarayourfriend
Copy link
Contributor

Fixes

In #1449 I added a ternary, but GH Workflow syntax doesn't support them 🤦 This replaces the ternary with the equivalent && || construct.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • [N/A] I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • [N/A] I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@sarayourfriend sarayourfriend added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 🤖 aspect: dx Concerns developers' experience with the codebase labels May 17, 2022
@sarayourfriend sarayourfriend requested a review from a team as a code owner May 17, 2022 12:35
@sarayourfriend sarayourfriend requested review from krysal and obulat May 17, 2022 12:35
@sarayourfriend sarayourfriend enabled auto-merge (squash) May 17, 2022 12:35
@github-actions
Copy link

github-actions bot commented May 17, 2022

Storybook and Tailwind configuration previews: Ready

Storybook: https://wordpress.github.io/openverse-frontend/1452
Tailwind: https://wordpress.github.io/openverse-frontend/1452/tailwind

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch 👍

Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sarayourfriend sarayourfriend merged commit 3f956c4 into main May 17, 2022
@sarayourfriend sarayourfriend deleted the fix/illegal-expressiong branch May 17, 2022 12:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants