-
Notifications
You must be signed in to change notification settings - Fork 63
Use i18n from useI18n composable instead of Nuxt context #1418
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1418 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, and I must appreciate the laser-sharp focus of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! This will make the bridge upgrade's so much less of a chore 😁
Size Change: -33 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
Fixes
Fixes #645 by @dhruvkb
Description
This PR uses the
useI18n
composable to get the app i18n in the components setup functions instead of getting it fromuseContext
. This will simplify conversion to Nuxt 3.Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin