This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Refactor license constants and utils #1393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhruvkb
added
🟩 priority: low
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1393 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
7 tasks
dhruvkb
changed the title
|
Size Change: +23.7 kB (+2%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
…into license_improv
…into license_improv
|
@dhruvkb can you add testing instructions (and fill out the checklist)? Thanks! |
|
@sarayourfriend done! |
sarayourfriend
approved these changes
May 10, 2022
krysal
reviewed
May 11, 2022
| @@ -21,7 +21,7 @@ export interface Media { | |||
|
|
|||
| license: License | |||
| license_version: LicenseVersion | |||
| license_url: string | |||
| license_url?: string | |||
There was a problem hiding this comment.
Why does the license_url change to an optional field?
There was a problem hiding this comment.
Practically it's never undefined, I added that just to ensure that things work even if it was undefined.
obulat
reviewed
May 14, 2022
obulat
reviewed
May 14, 2022
|
@obulat if you mean like for testing i18n, that'll be difficult because we only have the |
|
Oh, that's true! |
obulat
approved these changes
May 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors and cleans up in the implementation of license constants and utils and their usage in the code.
This PR increases the code's parity with the frontend. A similar effort on the frontend is happening in WordPress/openverse-api#685.
Testing Instructions
Since this is a refactor, there are no changes to test but rather the test is that there should be no changes.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin