This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Update VCheckbox component and its story #1392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1392 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
openverse-bot
added
the
🚦 status: awaiting triage
|
Size Change: -300 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
obulat
added
🟩 priority: low
sarayourfriend
approved these changes
May 5, 2022
Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
# Conflicts: # test/storybook/visual-regression/v-checkbox.spec.ts-snapshots/off-linux.png # test/storybook/visual-regression/v-checkbox.spec.ts-snapshots/on-linux.png
dhruvkb
approved these changes
May 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Related to WordPress/openverse#584 by @dhruvkb
Also related to the non-existent issue for typescriptifying components
Description
This PR:
*.svg?inlineSVG component for checkmark in VCheckboxactionstab.Testing Instructions
Run storybook. Try out different controls, checkout the emitted object in the actions tab.
Also try using the Filters checkboxes. They should work correctly.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin