-
Notifications
You must be signed in to change notification settings - Fork 63
Fix image size jumps on single result #1381
Conversation
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1381 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
Size Change: +84 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just had to check if the API was sending the dimensions in the response.
Fixes
Fixes #1340 by @AetherUnbound
Description
Ensures that thumbnails on the single result view occupy the fully avaliable width and height, and display at the same size as the full image.
Testing Instructions
Load a bunch of single image results and observe that there's no jumping in size between the thumbnail and full image. Throttling your connection, or loading particularly large images, can help make this easier to observe.
Additionally, compare to the production frontend and observe that images display at the same size.
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin