This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Fix back to search link for pages in other languages #1350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
🕹 aspect: interface
obulat
force-pushed
the
fix/back_to_search_link
branch
from
483cb32 to
6709400
Compare
krysal
approved these changes
Apr 29, 2022
There was a problem hiding this comment.
Your solution of passing the path instead of a boolean makes a lot of sense!
I added some tests in #1351 if you want to consider it, to me seems important to cover at least one more language (covering all sounds unrealistic/not very beneficial). Perhaps you can see more cases.
Thanks for fixing it!
Comment on lines
+6
to
+7
| declare module '*.svg?inline' { | ||
| const SVG: unknown |
There was a problem hiding this comment.
It's nice that at least this removes the warning on files using these imports :)
Co-authored-by: Krystle Salazar <krystle.salazar@automattic.com>
# Conflicts: # src/locales/po-files/openverse.pot # tsconfig.json
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1350 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
|
Size Change: -3.81 kB (0%) Total Size: 1.41 MB
ℹ️ View Unchanged
|
sarayourfriend
approved these changes
May 3, 2022
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1345 by @AetherUnbound
Description
This PR refactors the
VSearchBarLink, moving path computation to the parent component.It also enables TS-ifying components that use?inlineSVGs.I tried using
It worked locally, but failed in CI (Could not find module Vue or its types), so I just replaced it with a
VIcon.Considering that
nuxtjs/svgdoes not support Nuxt 3, it is probably better to gradually replace all the?inlinesvgs withVIconor<svg>elements.Testing Instructions
Search for something using localized sites (e.g. search-staging.openverse.engineering/ru/search/q=cat) and open one of the results. There should be 'Back to search results' link at the top, and it should go to the previous page. This should work for audio and images, from All Content, Images and Audio search pages.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin