This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Await fetching related media in the single result store #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
💻 aspect: code
krysal
reviewed
Apr 29, 2022
There was a problem hiding this comment.
I was wondering why the call to useRelatedMediaStore().fetchMedia() can't be async so inspecting Pinia in the single results page I found that the single-result store does not persist or it is not initialized, it's not shown in the list on Vue Devtools.
So making the call from the setup function instead of the single-result store seems to allow it to work asynchronously.
obulat
force-pushed
the
fix/fetch_related
branch
from
269d3b3 to
b908dc6
Compare
|
Thank you for catching this, @krysal ! |
# Conflicts: # src/locales/po-files/openverse.pot
|
Storybook and Tailwind configuration previews: Ready Storybook: https://wordpress.github.io/openverse-frontend/1349 Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again. You can check the GitHub pages deployment action list to see the current status of the deployments. |
|
Size Change: +44 B (0%) Total Size: 1.43 MB
ℹ️ View Unchanged
|
1 task
Yes, that's my suspicion, that the Pinia instance from the |
krysal
approved these changes
May 3, 2022
Comment on lines
+63
to
+65
| * If the result is available in the media store (from search results or related media), | ||
| * we can re-use it. Otherwise, we fetch it from the API. | ||
| * The media objects from the search results currently don't have filetype or filesize properties. |
There was a problem hiding this comment.
Why reuse it? 🤔 I'm not sure if we gain much from this optimization as the search endpoint doesn't return all the fields we need in the single result page.
There was a problem hiding this comment.
I didn't know that the search endpoint doesn't return all the fields when I implemented this. I think there are only filetype and filesize fields that are not returned currently. I think re-using still improves the performance of single result loading.
|
This fixes #1377 😁 |
1 task
The state data from the server is saved to Let's see how it goes now, and, if necessary, we can refactor later. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1339 by @AetherUnbound
Description
This PR adds
awaitto ensure that related media are fetched on SSR as well as on CSR.The related fetch call is moved after the main single result is fetched successfully.
Testing Instructions
Try loading a single result page on SSR, or opening a single result page and refreshing. The related media should be there.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin