This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Create VSourcesTable component #1317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openverse-bot
added
✨ goal: improvement
obulat
force-pushed
the
add/sources_table
branch
from
6e01371 to
3b0f1c6
Compare
7 tasks
sarayourfriend
approved these changes
Apr 24, 2022
| </template> | ||
|
|
||
| <script lang="ts"> | ||
| import sortBy from 'lodash.sortby' |
There was a problem hiding this comment.
TIL lodash.sortby is over 2300 LOC 😱 Good thing we have #1108 😁
| @@ -19,5 +19,4 @@ | |||
| @import 'components/image'; | |||
| @import 'components/navbar'; | |||
| @import 'components/card'; | |||
| @import 'components/table'; | |||
Comment on lines
+79
to
+80
| <h5>{{ $t('sources.heading.audio') }}</h5> | ||
| <VSourcesTable media="audio" /> |
|
It looks great. I like how the sort works. I noticed one thing. The header row should have Great work ✨ |
obulat
commented
May 2, 2022
|
Size Change: +27.1 kB (+2%) Total Size: 1.41 MB
|
|
I don't know why the hashed names are being used for the main branch, causing the size diff to fail like that |
zackkrida
approved these changes
May 3, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes #1088 by @zackkrida
Related to #1155 by @obulat (not fixes because no design decisions have been made yet)
Description
This PR creates a
VSourcesTablethat extracts all the table styles. It uses the second approach from the linked issue: instead of trying to implement a very generic table, it only creates a component specific for the Sources table. If/when we have other tables, we can either create a new component, or extract common styles/behaviors from this component.Other changes include:
table.scssdark-charcoal-06, font size set to 14pxTesting Instructions
Open the Sources page, try changing the sorting in the table.
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin