Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Fix focus style of buttons in page menu #1240

Merged
merged 1 commit into from
Apr 6, 2022
Merged

Conversation

krysal
Copy link
Member

@krysal krysal commented Apr 5, 2022

Following up #1191 that left out the items in the pages menu, as @obulat noticed.

Description

This PR makes the VItem component use always the variant plain of the VButton to keep focus-visible styles. I don't know in which cases the "plain-dangerous" version would be used, please point it out or describe it if you find it.

Testing Instructions

Navigate the pages menu in a version of Safari < 15.4 with the keyboard, you should see the focus ring in each page entry.

CleanShot 2022-04-05 at 14 38 27@2x

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal requested a review from a team as a code owner April 5, 2022 18:40
@krysal krysal self-assigned this Apr 5, 2022
@krysal krysal requested review from obulat and dhruvkb April 5, 2022 18:40
@krysal krysal added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix ♿️ aspect: a11y Concerns related to the project's accessibility labels Apr 5, 2022
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first looked at how it worked, and then opened the code. Didn't realize that the code change was so small :) Works very well!

@sarayourfriend
Copy link
Contributor

plain-dangerous was meant as a way to have a button with all the accessibility stuff bolted on but without any styles whatsoever, including focus styles.

This was useful for VItem because the designs for some breakpoints have the focus ring inside the button with the grey outline of the active button appearing around it, generally.

However, we don't use that version of the item anywhere in the app. And this actually fixes the focus outline for VItem in storybook on Firefox too!

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@krysal
Copy link
Member Author

krysal commented Apr 6, 2022

Thanks for explaining the reason behind the variant, @sarayourfriend! I guess we can revise it when the need arises.

@krysal krysal merged commit b8c79fd into main Apr 6, 2022
@krysal krysal deleted the fix/page-menu-items-focus branch April 6, 2022 16:48
krysal added a commit that referenced this pull request Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
♿️ aspect: a11y Concerns related to the project's accessibility 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants