Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add the 3D model SVG #1175

Merged
merged 2 commits into from
Mar 23, 2022
Merged

Add the 3D model SVG #1175

merged 2 commits into from
Mar 23, 2022

Conversation

zackkrida
Copy link
Member

@zackkrida zackkrida commented Mar 23, 2022

Fixes

Fixes #1122 by @panchovm

Description

Adds a new svg icon file for the 3D model icon.

Testing Instructions

Perhaps view the file in your browser? Maybe change the color svg {color: salmon} in css to confirm that currentColor is working?

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner March 23, 2022 17:45
@zackkrida zackkrida requested review from krysal and obulat March 23, 2022 17:45
@zackkrida zackkrida added this to the 3D Model Support [Q2 2022] milestone Mar 23, 2022
@zackkrida zackkrida changed the title Add the 3d model SVG to the repo Add the 3D model SVG Mar 23, 2022
@dhruvkb dhruvkb added 🌟 goal: addition Addition of new feature 🕹 aspect: interface Concerns end-users' experience with the software 🟨 priority: medium Not blocking but should be addressed soon labels Mar 23, 2022
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to wrap all the paths inside a g#icon so that VIcon can properly render it. You can see a different SVG for reference.

@zackkrida
Copy link
Member Author

That's right, thanks @dhruvkb. I don't love that pattern and we'll need to reassess using svg <use /> if we ever need more granular control of styling parts of icons, but I've updated the PR.

@zackkrida zackkrida requested a review from dhruvkb March 23, 2022 18:23
Copy link
Member

@dhruvkb dhruvkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now, we should make an RFC for the best way to use SVGs.

@zackkrida zackkrida merged commit e73839e into main Mar 23, 2022
@zackkrida zackkrida deleted the models-3d-icon branch March 23, 2022 21:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🌟 goal: addition Addition of new feature 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add 3D model icon svg to the project
3 participants