-
Notifications
You must be signed in to change notification settings - Fork 63
Conversation
"podcast": "Podcast", | ||
"pronunciation": "Pronunciation", | ||
"sound_effect": "Sound effects", | ||
"sound": "Sound effects" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sound
key is still required due to the API returning this value in some audios.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice touch to display it here but not include it in the filters 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! Thank you! 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! They look great. I look forward to us fixing #1169 next.
"podcast": "Podcast", | ||
"pronunciation": "Pronunciation", | ||
"sound_effect": "Sound effects", | ||
"sound": "Sound effects" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice touch to display it here but not include it in the filters 👍
Fixes
Related to WordPress/openverse#195 by @AetherUnbound
Description
Shows recently included categories in the catalog in the filters and translate the string in the audio details page.
Testing Instructions
Run the project and see the new categories in audio filters, as well as the category translated in the audio details page (try a non-English locale).
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin