Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Update audio categories #1168

Merged
merged 6 commits into from
Mar 23, 2022
Merged

Update audio categories #1168

merged 6 commits into from
Mar 23, 2022

Conversation

krysal
Copy link
Member

@krysal krysal commented Mar 22, 2022

Fixes

Related to WordPress/openverse#195 by @AetherUnbound

Description

Shows recently included categories in the catalog in the filters and translate the string in the audio details page.

Testing Instructions

Run the project and see the new categories in audio filters, as well as the category translated in the audio details page (try a non-English locale).

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • [N/A] I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@krysal krysal added 🟥 priority: critical Must be addressed ASAP ✨ goal: improvement Improvement to an existing user-facing feature 📄 aspect: text Concerns the textual material in the repository labels Mar 22, 2022
@krysal krysal requested a review from a team as a code owner March 22, 2022 21:19
@krysal krysal self-assigned this Mar 22, 2022
@krysal krysal requested review from obulat and dhruvkb March 22, 2022 21:19
"podcast": "Podcast",
"pronunciation": "Pronunciation",
"sound_effect": "Sound effects",
"sound": "Sound effects"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sound key is still required due to the API returning this value in some audios.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch to display it here but not include it in the filters 👍

Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Thank you! 😄

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! They look great. I look forward to us fixing #1169 next.

"podcast": "Podcast",
"pronunciation": "Pronunciation",
"sound_effect": "Sound effects",
"sound": "Sound effects"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice touch to display it here but not include it in the filters 👍

@krysal krysal merged commit 0a95be1 into main Mar 23, 2022
@krysal krysal deleted the audio_categories branch March 23, 2022 19:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
📄 aspect: text Concerns the textual material in the repository ✨ goal: improvement Improvement to an existing user-facing feature 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants