Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

updated dev dependencies -> eslint ts-node tailwindcss ...etc #1125

Closed
wants to merge 3 commits into from
Closed

updated dev dependencies -> eslint ts-node tailwindcss ...etc #1125

wants to merge 3 commits into from

Conversation

kb-0311
Copy link
Contributor

@kb-0311 kb-0311 commented Mar 15, 2022

Fixes

Fixes #1086 by @krysal

Description

updated devdDependencies ->
eslint
ts-node
tailwindcss
postcss
autoprefixer
eslint-plugin-unicorn

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@kb-0311 kb-0311 requested a review from a team as a code owner March 15, 2022 23:51
@kb-0311 kb-0311 requested review from krysal and dhruvkb March 15, 2022 23:51
@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Mar 15, 2022
@kb-0311
Copy link
Contributor Author

kb-0311 commented Mar 15, 2022

Getting the same storybuild error that my previous dev dependency update PR had for some reason.

@kb-0311 kb-0311 changed the title updated dev dependencies -> eslint ts-node tailwindcss postcss autopr… updated dev dependencies -> eslint ts-node tailwindcss ...etc Mar 16, 2022
@sarayourfriend
Copy link
Contributor

@kb-0311 I'm not sure why but that failure happens intermittently 😕

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ESLint failure looks like it should be fixed by updating the unicorn plugin as well: sindresorhus/eslint-plugin-unicorn#1486

Specifically it's due to this ESLint 8 breaking change: https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#remove-lib

Can you update eslint-plugin-unicorn as well? Thanks!

@kb-0311
Copy link
Contributor Author

kb-0311 commented Mar 16, 2022

I was planning to update all the eslint-plugins Dev Deps in one PR itself .

But I will update the unicorn one rn,

Also there are some branch conflicts with main branch .. can you check that out and how to resolve it ? Thanks.

@kb-0311
Copy link
Contributor Author

kb-0311 commented Mar 17, 2022

again E2E failed for some reason else everything else is good to go.

Resolved the branch conflicts and updated eslint-plugin-unicorn but still cannot under why the E2E error is there ? Still the nuxt story book compatibility issue ? If yes would updating that dev dependency resolve that ?

@sarayourfriend
Copy link
Contributor

The e2e error doesn't look related to storybook (we don't currently run e2e tests against storybook). It might be the same errors that @obulat referenced in #1131?

@kb-0311
Copy link
Contributor Author

kb-0311 commented Mar 17, 2022

@sarayourfriend hmm then ig this PR is good to go.

Ig when #1131 is merged then this E2E will be resolved too , right ?

@sarayourfriend
Copy link
Contributor

Potentially yes. I'd feel more comfortable holding this PR until Olga's is merged just so we're sure we're not introducing any potential regression with these changes.

There's no rush for this PR to be merged ASAP as it currently stands, so we can wait and be safe.

@sarayourfriend sarayourfriend added the 🚧 status: blocked Blocked & therefore, not ready for work label Mar 17, 2022
@kb-0311
Copy link
Contributor Author

kb-0311 commented Mar 17, 2022

Yes agreed .

Pls add a comment here once #1131 is merged and if there are some additional changes to be made here : )

This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon 🚧 status: blocked Blocked & therefore, not ready for work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated dependencies
3 participants