-
Notifications
You must be signed in to change notification settings - Fork 63
updated dev dependencies -> eslint ts-node tailwindcss ...etc #1125
Conversation
Getting the same storybuild error that my previous dev dependency update PR had for some reason. |
@kb-0311 I'm not sure why but that failure happens intermittently 😕 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The ESLint failure looks like it should be fixed by updating the unicorn plugin as well: sindresorhus/eslint-plugin-unicorn#1486
Specifically it's due to this ESLint 8 breaking change: https://eslint.org/docs/8.0.0/user-guide/migrating-to-8.0.0#remove-lib
Can you update eslint-plugin-unicorn
as well? Thanks!
I was planning to update all the eslint-plugins Dev Deps in one PR itself . But I will update the unicorn one rn, Also there are some branch conflicts with main branch .. can you check that out and how to resolve it ? Thanks. |
again E2E failed for some reason else everything else is good to go. Resolved the branch conflicts and updated |
@sarayourfriend hmm then ig this PR is good to go. Ig when #1131 is merged then this E2E will be resolved too , right ? |
Potentially yes. I'd feel more comfortable holding this PR until Olga's is merged just so we're sure we're not introducing any potential regression with these changes. There's no rush for this PR to be merged ASAP as it currently stands, so we can wait and be safe. |
Yes agreed . Pls add a comment here once #1131 is merged and if there are some additional changes to be made here : ) |
Fixes
Fixes #1086 by @krysal
Description
updated devdDependencies ->
eslint
ts-node
tailwindcss
postcss
autoprefixer
eslint-plugin-unicorn
Testing Instructions
Checklist
Update index.md
).main
) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin