Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Switch to css grid instead of legacy column classes in media reuse #1092

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

zackkrida
Copy link
Member

Fixes

Fixes #1091 by @zackkrida

Description

Switches the media reuse columns to use flexbox for layout. Observe an image and/or audio single result on desktop and mobile; confirm the correct appearance.

Testing Instructions

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@zackkrida zackkrida requested a review from a team as a code owner March 9, 2022 21:21
@zackkrida zackkrida requested review from krysal and obulat March 9, 2022 21:21
@dhruvkb dhruvkb added 💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon labels Mar 9, 2022
Copy link
Contributor

@obulat obulat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great to remove the old Bulma classes, but this solution causes more movement between columns when switching between VCopyLicense tabs.

The left column is too narrow when in the HTML tab, can we prevent this?

CleanShot 2022-03-10 at 10 21 25

@zackkrida
Copy link
Member Author

ah, thanks @krysal ! I can easily make the columns the same width, i can't believe i missed that 😅

@zackkrida zackkrida changed the title Switch to flexbox instead of legacy column classes in media reuse Switch to css grid instead of legacy column classes in media reuse Mar 10, 2022
@zackkrida zackkrida requested a review from krysal March 10, 2022 15:55
Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, perfect!

@zackkrida zackkrida merged commit b283805 into main Mar 10, 2022
@zackkrida zackkrida deleted the media-reuse-columns branch March 10, 2022 21:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media reuse uses legacy columns classes
4 participants