Removed iframe-height.js and its implementations

[BarokDG]

Fixes

Fixes #1059 by @zackkrida

Description

I deleted iframe-height.js inside src/mixins/ and removed all imports of that file inside src/layouts/blank.vue, src/layouts/default.vue, and src/pages/audio/_id.vue. I also removed a comment explaining the use of a resize event but undid it in a second commit.

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[BarokDG]

I can't figure out how to add labels. Can anyone tell me?

[sarayourfriend]

This is great @BarokDG thanks for the contribution and welcome to Openverse! 🎉

I think we can keep the change you made originally to remove the resize, what was the reason for reverting that?

[BarokDG]

This is great @BarokDG thanks for the contribution and welcome to Openverse! 🎉

I think we can keep the change you made originally to remove the resize, what was the reason for reverting that?

I couldn't see where the 'resize' value was used and there is another reference to 'resize' at the top of the comment. I wanted confirmation before I changed it. Should I remove both references?

[sarayourfriend]

Should I remove both references?

Please do, thanks!

[BarokDG]

Done! I also removed a switch case for the 'resize' event in iframe-test.html.

Anything I can do about the "CI/Check translation files" check?

[krysal]

@BarokDG You only need to run pnpm i18n:generate-pot and commit the updated .pot file to pass that check.

[BarokDG]

I followed the instructions but the "CI=1 pnpm i18n:generate-pot" command is returning a success message. I decided to try and just commit an updated openverse.pot file but the check is still failing.

[sarayourfriend]

Oh dear! It seems our POT file generation is clashing with Windows path delimiters! I created this issue to address that: #1066

For now I'll push the updated file so the check passes for you. Sorry about that!

[BarokDG]

Oh dear! It seems our POT file generation is clashing with Windows path delimiters! I created this issue to address that: #1066

For now I'll push the updated file so the check passes for you. Sorry about that!

It's alright. This was my first ever contribution. Thanks a lot for being so helpful and kind!

Edit: Thanks to all of you, not just @sarayourfriend😄

[obulat]

Thank you for your contribution, @BarokDG ! It works great.
I'm sorry about the Windows incompatibility.

[krysal]

Everything seems correct. Thank you @BarokDG!