changed the scroll to top button color B->P

[kb-0311]

Fixes

Fixes #1032 by @zackkrida

Description

Changed the scroll to the top button component color from blue to pink

Testing Instructions

Checklist

• My pull request has a descriptive title (not a vague title like Update index.md).
• My pull request targets the default branch of the repository (main) or a parent feature branch.
• My commit messages follow best practices.
• My code follows the established code style of the repository.
• I added or updated tests for the changes I made (if applicable).
• I added or updated documentation (if applicable).
• I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin

Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

[kb-0311]

I am not sure how to add labels to a pull request and how to eliminate the errors can someone please help me out with this

[kb-0311]

thanks @sarayourfriend

[kb-0311]

There are some end to end errors, not sure due to the bg color change or some other issue-

1 failed
    migration-banner.spec.js:13:1 › migration banner goes away on navigation =======================
  2 skipped
  39 passed (1m)
Error: Command failed with exit code 1: npm run test:e2e
    at makeError (/home/runner/work/openverse-frontend/openverse-frontend/node_modules/.pnpm/execa@5.1.1/node_modules/execa/lib/error.js:60:11)
    at handlePromise (/home/runner/work/openverse-frontend/openverse-frontend/node_modules/.pnpm/execa@5.1.1/node_modules/execa/index.js:118:26)
    at processTicksAndRejections (node:internal/process/task_queues:96:5) {
  shortMessage: 'Command failed with exit code 1: npm run test:e2e',
  command: 'npm run test:e2e',

Can some one pls suggest some changes I could make ?

[obulat]

Could you change the colors:
bg-trans-pink: bg-pink
hover:bg-trans-pink-action: bg-dark-pink

[obulat]

Thank you for your PR, @kb-0311 ! We are using Tailwind, and only some pre-configured colors are allowed in the class names. Here are the definitions of the pink that the button should use:

openverse-frontend/tailwind.config.js

Lines 27 to 31 in e23af1a

	// Brand
	yellow: '#ffe033',
	pink: '#c52b9b',
	// Active
	'dark-pink': '#7c2264',

There are no such colors as bg-trans-blue, that's why you are seeing the errors.

[kb-0311]

ohhh got it thanks also I made the changes you requested.

[kb-0311]

@obulat actually I am pretty sure I added the dark class instead of the trans class however still giving some E2E error.

[obulat]

Great! Your changes are correct, and the e2e failure is not related to them. Let me look into that.

[kb-0311]

ok thanks for your feedback hoping to contribute more to the project in the future

[obulat]

@kb-0311 , I think #1041 should fix the e2e failure, and once it's reviewed and merged, your PR should also pass.
Thank you for your contribution, and welcome to Openverse :)

[zackkrida]

Thank you!