Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Open external links in parent frame #983

Closed
dd32 opened this issue Feb 22, 2022 · 2 comments
Closed

Open external links in parent frame #983

dd32 opened this issue Feb 22, 2022 · 2 comments
Assignees
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents

Comments

@dd32
Copy link
Member

dd32 commented Feb 22, 2022

Description

The https://creativecommons.org/licenses/ link on the homepage is unclickable when loading via the WordPress.org/openverse iframe.

Reported here: https://meta.trac.wordpress.org/ticket/6124

Reproduction

  1. Visit https://wordpress.org/openverse/
  2. Click Creative Commons license
  3. See refused error.

Expectation

Load in parent frame.

Screenshots

See ticket

@dd32 dd32 added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Feb 22, 2022
@sarayourfriend
Copy link
Contributor

sarayourfriend commented Feb 22, 2022

Once #879 is deployed (hopefully within the next couple weeks) this should be fixed.
Edited to add the correct PR by obulat

@sarayourfriend sarayourfriend removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 22, 2022
@obulat
Copy link
Contributor

obulat commented Feb 22, 2022

Thank you for reporting this issue, @dd32 ! I am going to close it as a duplicate of #468 and because it's fixed in #879 (to be deployed)

@obulat obulat closed this as completed Feb 22, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

No branches or pull requests

3 participants