Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

External links NOT opening in the Openverse iframe #468

Closed
1 task done
obulat opened this issue Dec 2, 2021 · 0 comments · Fixed by #879
Closed
1 task done

External links NOT opening in the Openverse iframe #468

obulat opened this issue Dec 2, 2021 · 0 comments · Fixed by #879
Assignees
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents

Comments

@obulat
Copy link
Contributor

obulat commented Dec 2, 2021

Description

On the single image result page, a click on a creator's link causes error in an iframe due to x-frame settings.

Reproduction

  1. Go to any single result page, for example this one
  2. Click on the creator's name (pricklysarah)
  3. See an error:
  • in Firefox the iframe shows a warning "Firefox Can’t Open This Page. To protect your security, www.flickr.com will not allow Firefox to display the page if another site has embedded it. To see this page, you need to open it in a new window.", with a button to open the page in a new window
  • in Chrome, the iframe is gray and seems to be stuck, but there is a faint text saying "www.flickr.com refused to connect."

Expectation

The link should open. I think the best option would be to open it in a new tab. Another option is to set the target to the top window, so that the link opens in the same tab

Screenshots

image

Additional context

Because the iframe height was previously set to a high number (around 3000px), it is also hard to see the error message in Chrome, as it appears much lower than the fold.

Resolution

  • 🙋 I would be interested in resolving this bug.
@obulat obulat added 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Dec 2, 2021
@zackkrida zackkrida added the bug Something isn't working label Feb 4, 2022
@obulat obulat removed the 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work label Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository bug Something isn't working 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
2 participants