Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Pages menu final item does not have correct bottom margin #2008

Closed
1 task
sarayourfriend opened this issue Nov 25, 2022 · 4 comments · Fixed by #2030
Closed
1 task

Pages menu final item does not have correct bottom margin #2008

sarayourfriend opened this issue Nov 25, 2022 · 4 comments · Fixed by #2030
Assignees
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon

Comments

@sarayourfriend
Copy link
Contributor

Description

image

Reproduction

Visit any page (https://search-staging.openverse.engineering/search/?q=galah, for example), and open the pages menu (the three dots menu next to the search bar) and focus/hover over the final item in the dropdown menu. Focusing/hovering shows the incorrect margin very clearly, but it is still wrong when unfocused (i.e., it's not an issue with the focus box).

Resolution

  • 🙋 I would be interested in resolving this bug.
@sarayourfriend sarayourfriend added good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Nov 25, 2022
@rajdeepdas2000
Copy link
Contributor

🙋 I would be interested in resolving this bug.

@sarayourfriend
Copy link
Contributor Author

@rajdeepdas2000 Thank you! I've assigned the issue to you. If you have any questions, feel free to ping the maintainers at @WordPress/openverse-frontend for help.

@rajdeepdas2000
Copy link
Contributor

rajdeepdas2000 commented Dec 8, 2022

Hi @sarayourfriend I managed to solve the issue using inspect element from the browser but I am unable to find the exact file in which the change is to be made. Can you help me with the filename and its location where the changes are to made?

@rajdeepdas2000
Copy link
Contributor

I have raised PR #2037 to solve this issue. Kindly look into the PR. Thanks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟨 priority: medium Not blocking but should be addressed soon
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants