Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Text styles in no results page are incorrect #1588

Closed
1 task
fcoveram opened this issue Jul 26, 2022 · 2 comments · Fixed by #1613
Closed
1 task

Text styles in no results page are incorrect #1588

fcoveram opened this issue Jul 26, 2022 · 2 comments · Fixed by #1613
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🎨 tech: css Requires familiarity with CSS

Comments

@fcoveram
Copy link

Description

Title and description texts in the no results page do not follow the styles defined in the mockup. H1 should be Heading 4 and the text below be Description regular.

Reproduction

  1. Open openverse on mobile or within the smallest breakpoint.
  2. Search for "asd32asda"
  3. Notice that title and description texts, above source links, are bigger than mockups.

Screenshots

Implementation Design
CleanShot 2022-07-26 at 14 36 56@2x CleanShot 2022-07-26 at 14 35 21@2x

Resolution

  • 🙋 I would be interested in resolving this bug.
@fcoveram fcoveram added 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🕹 aspect: interface Concerns end-users' experience with the software labels Jul 26, 2022
@zackkrida zackkrida added good first issue New-contributor friendly help wanted Open to participation from the community 🎨 tech: css Requires familiarity with CSS 🖼️ aspect: design Concerns related to design 🟩 priority: low Low priority and doesn't need to be rushed and removed 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🖼️ aspect: design Concerns related to design labels Jul 26, 2022
@RudyBecker
Copy link

Working on this issue!

@zackkrida zackkrida mentioned this issue Aug 2, 2022
Merged
7 tasks
@RudyBecker
Copy link

My friend kickeyhickey will be creating a PR for this! Thanks!

@RARNE12 RARNE12 mentioned this issue Aug 4, 2022
Closed
5 tasks
@krysal krysal assigned krysal and unassigned krysal Aug 4, 2022
zackkrida added a commit that referenced this issue Aug 8, 2022
@kickeyhickey @obulat @zackkrida
Text styles in no results page are incorrect #1588 (#1613)
5a135ce 
Co-authored-by: Olga Bulat <obulat@gmail.com>
Co-authored-by: Krystle Salazar <krystle.salazar2@gmail.com>
Co-authored-by: Zack Krida <zackkrida@pm.me>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
🕹 aspect: interface Concerns end-users' experience with the software 🛠 goal: fix Bug fix good first issue New-contributor friendly help wanted Open to participation from the community 🟩 priority: low Low priority and doesn't need to be rushed 🎨 tech: css Requires familiarity with CSS
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Text styles in no results page are incorrect #1588 kickeyhickey/openverse-frontend
4 participants
@fcoveram @zackkrida @krysal @RudyBecker