Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Commit

Permalink
Remove one place that playwright version is duplicated
Browse files Browse the repository at this point in the history
  • Loading branch information
sarayourfriend committed Mar 4, 2022
1 parent fb68359 commit 0c18ba8
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 2 deletions.
10 changes: 8 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -70,9 +70,15 @@ jobs:
steps:
- uses: actions/checkout@v2

# E2E runs inside docker and doesn't need any node dependencies
# E2E tests run inside docker container and don't need installed deps,
# but we still need to use `pnpm ls` to determine what the specific
# version of playwright being used in pnpm-lock.yaml is
- uses: pnpm/action-setup@v2.0.1
with:
version: 6.30.1

- name: Run E2E
run: PLAYWRIGHT_VERSION=1.17.1 TEST_TYPE=e2e docker-compose -f docker-compose.playwright.yml up --abort-on-container-exit --exit-code-from playwright
run: ./bin/playwright.sh

storybook:
name: Check Storybook build
Expand Down
8 changes: 8 additions & 0 deletions bin/playwright.sh
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
#! /bin/bash'

# todo: find a way to make this portable for Windows users so it can be used for the package.json script

export PLAYWRIGHT_VERSION=$(pnpm ls --dev --depth=0 | grep playwright | awk '{print $2}')
TEST_TYPE=$1 docker-compose -f docker-compose.playwright.yml up \
--abort-on-container-exit \
--exit-code-from playwright

0 comments on commit 0c18ba8

Please sign in to comment.