Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Allow more than one argument to recipe up #981

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Allow more than one argument to recipe up #981

merged 1 commit into from
Oct 19, 2022

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Oct 18, 2022

Description

This PR allows passing more than one argument to the recipe up, thereby enabling commands like the following:

$ just up --force-recreate web

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb added 🟩 priority: low Low priority and doesn't need to be rushed ✨ goal: improvement Improvement to an existing user-facing feature 🤖 aspect: dx Concerns developers' experience with the codebase labels Oct 18, 2022
@dhruvkb dhruvkb requested a review from a team as a code owner October 18, 2022 20:24
@github-actions
Copy link

github-actions bot commented Oct 18, 2022

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/981

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sarayourfriend
Copy link
Contributor

FWIW the workaround for this is to quote the arguments, if you're ever in a bind and can't make changes like this to a more complex recipe:

#  just up "--force-recreate web"

@dhruvkb
Copy link
Member Author

dhruvkb commented Oct 19, 2022

Great workaround @sarayourfriend, thanks!

@dhruvkb dhruvkb merged commit 6cdf5b6 into main Oct 19, 2022
@dhruvkb dhruvkb deleted the up_star branch October 19, 2022 04:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase ✨ goal: improvement Improvement to an existing user-facing feature 🟩 priority: low Low priority and doesn't need to be rushed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants