Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Add kwarg 'child' required by seriaizers.ListField #434

Merged
merged 1 commit into from
Dec 27, 2021
Merged

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Dec 27, 2021

This PR fixes a missing keyword argument in ListField which gives warnings or errors in CI. This was contributed in several PRs

so merging it separately while removing it from the PRs would prevent them from "eventually conflicting".

Description

serializers.ListField requires that the child-field be passed as a keyword argument 'child' and not as a positional argument. This requirement is addressed by the PR.

Testing Instructions

Passing CI is sufficient.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main) or a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
@dhruvkb dhruvkb added 🟧 priority: high Stalls work on the project or its dependents 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Dec 27, 2021
@dhruvkb dhruvkb requested a review from a team as a code owner December 27, 2021 06:19
Copy link
Contributor

@AetherUnbound AetherUnbound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks for making this a separate PR

@dhruvkb dhruvkb merged commit 34fdd50 into main Dec 27, 2021
@dhruvkb dhruvkb deleted the fix_child branch December 27, 2021 09:53
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants