Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Define integration tests for audio (and general improvements) #160

Merged
merged 18 commits into from
Aug 13, 2021

Conversation

dhruvkb
Copy link
Member

@dhruvkb dhruvkb commented Aug 5, 2021

Dependencies

Please merge #108 before this.

Description

This PR adds integration tests for audio, while making general code quality improvements in the areas of code duplication and organisation.

This is not a comprehensive set of tests for all audio functionality, but these tests help to establish the basic working of audio endpoints.

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@dhruvkb dhruvkb marked this pull request as ready for review August 10, 2021 09:22
@dhruvkb dhruvkb requested a review from a team as a code owner August 10, 2021 09:22
@dhruvkb dhruvkb requested review from zackkrida and obulat and removed request for a team August 10, 2021 09:22
@dhruvkb dhruvkb added the 🌟 goal: addition Addition of new feature label Aug 10, 2021
@dhruvkb dhruvkb added the 🤖 aspect: dx Concerns developers' experience with the codebase label Aug 11, 2021
Base automatically changed from audio_endpoints to main August 12, 2021 13:53
Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really wonderful work. ran the api and tests locally without issue.

Copy link
Member

@krysal krysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean code separation as always 👍

openverse-api/test/media_integration.py Show resolved Hide resolved
openverse-api/test/run_test.sh Show resolved Hide resolved
@dhruvkb dhruvkb merged commit 39878b9 into main Aug 13, 2021
@dhruvkb dhruvkb deleted the audio_tests branch August 13, 2021 23:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
🤖 aspect: dx Concerns developers' experience with the codebase 🌟 goal: addition Addition of new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants