This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add media type to content provider #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
obulat
reviewed
Jul 21, 2021
|
It'll make filtering complicated. Can we not keep two different providers with the same display name but different IDs (like Wikimedia internally stored as wikimedia_images and wikimedia_audio)? |
zackkrida
approved these changes
Aug 3, 2021
Yeah i think this is fine for now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are now adding new media types, the
ContentProvidermodel needs to specify which media type it provides. This PR adds the newmedia_typefield to theContentProvidermodel.