Skip to content
This repository has been archived by the owner on Feb 22, 2023. It is now read-only.

Handle tally cases where results is None #1132

Merged
merged 3 commits into from
Feb 6, 2023

Conversation

AetherUnbound
Copy link
Contributor

Fixes

Fixes #1131 by @AetherUnbound

Description

This PR initializes results_to_tally to either results or [] so that any operations on it which assume it's a list will behave correctly.

Testing Instructions

  1. Check out commit 65f2df5 and run just api-test - tests should fail and emulate current behavior
  2. Check out the tip of this branch and run just api-test - tests should now pass!

Checklist

  • My pull request has a descriptive title (not a vague title like
    Update index.md).
  • My pull request targets the default branch of the repository (main) or
    a parent feature branch.
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no visible
    errors.

Developer Certificate of Origin

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@AetherUnbound AetherUnbound requested a review from a team as a code owner February 6, 2023 21:26
@openverse-bot openverse-bot added 🟥 priority: critical Must be addressed ASAP 🛠 goal: fix Bug fix 💻 aspect: code Concerns the software code in the repository labels Feb 6, 2023
@github-actions
Copy link

github-actions bot commented Feb 6, 2023

API Developer Docs Preview: Ready

https://wordpress.github.io/openverse-api/_preview/1132

Please note that GitHub pages takes a little time to deploy newly pushed code, if the links above don't work or you see old versions, wait 5 minutes and try again.

You can check the GitHub pages deployment action list to see the current status of the deployments.

Copy link
Member

@zackkrida zackkrida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@sarayourfriend sarayourfriend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one suggestion for clarifying the test's scenario.

Co-authored-by: sarayourfriend <24264157+sarayourfriend@users.noreply.github.com>
@AetherUnbound AetherUnbound merged commit 3204b6e into main Feb 6, 2023
@AetherUnbound AetherUnbound deleted the hotfix/results-none#1131 branch February 6, 2023 23:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟥 priority: critical Must be addressed ASAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Results may be None during tallying
4 participants