This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Fixes https://github.com/WordPress/openverse-infrastructure/issues/332 by @AetherUnbound
Description
This PR changes the API and API nginx images to include the image tag as a part of the built docker images, so it can be referenced appropriately once the service is deployed without having to alter the ECS task definition every time.
The logic I've added should use the github SHA as the
SEMANTIC_VERSION
for all pushes to main, but use the ref name (e.g. tag version like "v2.5.10") for all releases.Testing Instructions
Very hard to test GitHub actions, this is based off of similar work on the frontend so I'm hoping it works!
Checklist
Update index.md
).main
) ora parent feature branch.
errors.
Developer Certificate of Origin
Developer Certificate of Origin