Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Framework: Replace element-closest with registered vendor script #9750

Merged
merged 7 commits into from
Sep 17, 2018
Merged

Framework: Replace element-closest with registered vendor script #9750

merged 7 commits into from
Sep 17, 2018

Commits on Sep 13, 2018

  1. Framework: Replace element-closest with registered vendor script

    @aduth
    aduth committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    d0cb647 View commit details
    Browse the repository at this point in the history

  2. Scripts: Add support for license ignore

    @aduth
    aduth committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    68bc9e7 View commit details
    Browse the repository at this point in the history

  3. Framework: Re-pin to newer version of JSDOM 

    Newer version is SemVer-compatible with jest-environment-jsdom and includes support for Element#closest out of the box.

jsdom/jsdom#1555

Required to ignore license validation for abab because while it is a compatible license (BSD 3-clause), the package's `license` field is malformed for parse.

https://github.com/jsdom/abab/blob/4327de3aae348710094d9f3c1f0c1477d9feb865/package.json#L26
https://github.com/jsdom/abab/blob/master/LICENSE.md
    @aduth
    aduth committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    92bc67d View commit details
    Browse the repository at this point in the history

  4. Testing: Add dummy testURL for Jest config 

    Avoids issues with localStorage in JSDOM 11.12

Can be removed when running Jest 23.5.0 or newer

See: jestjs/jest#6766
See: jestjs/jest#6792
    @aduth
    aduth committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    02abe3f View commit details
    Browse the repository at this point in the history

  5. Licenses: Add BSD-3-Clause W3C variant as an allowed license 

    Also, check if the license defined in package.json is telling us to look in the license file, instead.
    @pento @aduth
    pento authored and aduth committed Sep 13, 2018
    Configuration menu
    Copy the full SHA
    437b39b View commit details
    Browse the repository at this point in the history

Commits on Sep 17, 2018

  1. Package: Scripts: Use String#includes for improved code clarity

    @aduth
    aduth committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    2cc72cc View commit details
    Browse the repository at this point in the history

  2. Package: Scripts: Add CHANGELOG notes for improved license file detec… 

    …tion
    @aduth
    aduth committed Sep 17, 2018
    Configuration menu
    Copy the full SHA
    4376ae2 View commit details
    Browse the repository at this point in the history