Framework: Use @babel/runtime universally #9641
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
|
Closing this one in favor of #9643. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9640
Related: #8580, #8586
Alternative to: #9643
This pull request seeks to remove usage of
@babel/runtime-corejs2in an effort to resolve issues with loading the editor in Internet Explorer. This work is largely speculative, though is verified as a fix to the issue described in #9640. I'm not entirely clear on the context provided in #8580 and #8586, but as best I can tell the use of@babel/runtime-corejs2was specific to how packages were built for npm consumption. Since, as far as I'm aware, this is no longer the case as of #9171, there should not be expected a regression on #8580.Testing instructions:
Repeat Steps to Reproduce described in #9640 both in Internet Explorer and your preferred browser, verifying that the editor loads as expected.