Treat Verse lines consistently on the front end #9584
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
approved these changes
Sep 5, 2018
youknowriad
reviewed
Sep 5, 2018
| pre.wp-block-verse { | ||
| white-space: nowrap; | ||
| overflow: auto; | ||
| } |
There was a problem hiding this comment.
Should we remove the corresponding styles from editor.scss?
There was a problem hiding this comment.
I'd wondered about that too and was on the fence. It nice to see all relevant properties in a single file. Some other blocks have property duplication between editor.scss and style.scss, so I just went with duplicating for now.
Thanks for merging, @youknowriad.
|
Got a confirmation that this is fine design wise |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Today, we prevent wrapping Verse block lines in the editor because we want to preserve the author's intent, but that intent is not respected consistently on the front end where certain themes wrap Verse lines. This PR simply adds a rule to prevent Verse lines from wrapping on the front end in addition to the editor.
Fixes #4138.
How has this been tested?
I loaded a Verse block with a long line in the following themes and verified it was not wrapped: