Text Columns block: change title/description to include deprecation notice. #9358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
|
I just created a PR for adding the Text Columns → Columns transform: #9364. |
ZebulanStanphill
deleted the
update/make-text-columns-deprecation-more-obvious
branch
|
@youknowriad This needs to be added to the 3.7 milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a minor change which makes it more obvious for the average user to see that the Text Columns block is deprecated. Previously, warnings were only shown in the JavaScript console. This PR adds (deprecated) to the block title and changes the description to recommend usage of the Columns block instead. This should make it more obvious that the block is deprecated.
Additional notes
I wanted to also add the ability to transform a Text Columns block into a Columns block, but that is a much trickier task, so I am not doing it in this PR.
If anyone with more experience wants to do that, then please do.I have created a separate PR for that: #9364. I think providing one-way transforms from deprecated blocks to their recommended replacements/closest-equivalents is a good idea for smooth transitions.Ideally, you would want to automatically transform deprecated blocks into the recommended replacements, but the deprecated blocks API does not currently support migrating from/to a completely different block.
Related issues and PRs