Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix to allow publishing pages #9082

Merged
merged 1 commit into from
Aug 17, 2018
Merged

Fix to allow publishing pages #9082

merged 1 commit into from
Aug 17, 2018

Conversation

oandregal
Copy link
Member

@oandregal oandregal commented Aug 17, 2018 •
edited
Loading

How to reproduce the bug:

  • Add a new page
  • Try to publish it

Expected behavior is that the pre-publish panel would be opened. Instead, I've got:

error-publish-page

@oandregal oandregal self-assigned this Aug 17, 2018
@oandregal oandregal added the [Type] Bug An existing feature does not function as intended label Aug 17, 2018
tofumatt
tofumatt approved these changes Aug 17, 2018
View reviewed changes
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should get this in ASAP as a patch, but I'm shocked we don't have an end-to-end test that would catch this. We definitely should add one. 😓

@oandregal oandregal merged commit a6c41df into master Aug 17, 2018
@oandregal oandregal deleted the fix/publish-pages branch August 17, 2018 11:51
@tofumatt tofumatt mentioned this pull request Aug 17, 2018
Closed
@oandregal oandregal mentioned this pull request Aug 17, 2018
Merged
9 tasks
@mcsf mcsf added this to the 3.6 milestone Aug 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tofumatt tofumatt tofumatt approved these changes

@mcsf mcsf mcsf approved these changes

Assignees

@oandregal oandregal

Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.6
Development

Successfully merging this pull request may close these issues.
3 participants
@oandregal @tofumatt @mcsf