Testing: Trigger E2E test failure on console logging #8721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Type] Automated Testing
gziolo
approved these changes
Aug 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to enhance end-to-end tests to protect against unexpected console logging. While our use of
jest-puppeteerwill capture and fail tests onpageerrorevents, often we have other errors which occur that either do not crash the page or are captured by the top-level application error handler and handled gracefully. This console monitoring should also help protect against internal use of deprecated functionality.Implementation notes:
One point of stability I introduced here is automated handling of teardown of
pageevent bindings. We should probably apply this tobrowseras well, and probably onafterEach, to improve isolation between tests and avoid event handler leaking. This should be done separately.Testing instructions:
Verify end-to-end tests pass successfully:
You can trigger a failure by introducing a
console.errorsomewhere which would be covered by E2E tests.