DOM: Abort selection range set on unset range target #8691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Type] Bug
|
Nice! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8676
This pull request seeks to resolve an issue where merging two empty paragraph blocks which were created while at the end of an inline boundary would result in an uncaught error.
Implementation notes:
We were relying on a bogus node from TinyMCE to be present. Regardless of whether we should be concerned about an inconsistency in the presence of this node, the
placeCaretAtHorizontalEdgefunction should be resilient in handling an empty contentEditable.Testing instructions:
Repeat testing instructions from #8676, ensuring that no error is encountered.
Ensure end-to-end tests pass: