Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set fixed version of @babel/runtime to 7.0.0-beta.55 #8582

Closed
wants to merge 1 commit into from

Conversation

abotteram
Copy link
Contributor

Description

Set the version of @babel/runtime to the latest working version for @WordPress packages.

Fixes: #8580

How has this been tested?

Screenshots

Types of changes

Bug fix

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.

@abotteram abotteram requested a review from a team August 6, 2018 09:12
@moorscode
Copy link
Contributor

This should be a temporary fix. Preferred to set the minimal required version to 5.6 and adjust the code to work with the breaking changes introduced in that version.

@youknowriad
Copy link
Contributor

What would be the fix if we want to upgrade to the last version?

@gziolo
Copy link
Member

gziolo commented Aug 6, 2018

Yes, it would be nice to bump to the latest Babel version instead :)

@ntwb
Copy link
Member

ntwb commented Aug 6, 2018

Why not upgrade the underlying issue?

i.e upgrade from @babel/runtime to @babel/runtime-corejs2

See also https://babeljs.io/docs/en/next/babel-runtime

@abotteram abotteram closed this Aug 6, 2018
@ntwb ntwb deleted the fix/set-fixed-version-of-babel-runtime branch August 6, 2018 10:25
@abotteram
Copy link
Contributor Author

@ntwb @gziolo @youknowriad but we should also set a fixed version for babel packages as long as it is in beta.

@ntwb
Copy link
Member

ntwb commented Aug 6, 2018

@xyfi It has been in beta for quite some time and we are using beta features I believe, @gziolo can also explain why the ^ caret is used, I believe it is a Lerna v3 functionality we are able to leverage that would not be typically used in a single repo Node.js project.

@gziolo
Copy link
Member

gziolo commented Aug 6, 2018

In general, we want to use sem ver for packages to make them more flexible when integrating with other projects. However in case of Babel, we probably should avoid doing that because they are introducing breaking changes :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@babel/runtime 7.0.0-beta.56 Causes build errors when using various packages.
5 participants