Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DomReady: Fix race condition #8578

Merged
merged 1 commit into from
Aug 6, 2018
Merged

DomReady: Fix race condition #8578

merged 1 commit into from
Aug 6, 2018

Conversation

youknowriad
Copy link
Contributor

backport https://meta.trac.wordpress.org/changeset/7593

closes #8455

This fixes a race condition in wp.domReady that can cause the Gutenberg page to show just a blank page. I think to reproduce it you need to:

  • Have a post with big images not cached in the browser
  • Try to edit the post in Gutenberg
    • wp.api.init resolve should resolve before the images load

@youknowriad youknowriad added the [Type] Bug An existing feature does not function as intended label Aug 6, 2018
@youknowriad youknowriad self-assigned this Aug 6, 2018
@youknowriad youknowriad requested review from omarreiss and a team August 6, 2018 08:30
@youknowriad youknowriad mentioned this pull request Aug 6, 2018
Closed
omarreiss
omarreiss approved these changes Aug 6, 2018
View reviewed changes
Copy link
Member

@omarreiss omarreiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@youknowriad youknowriad mentioned this pull request Aug 6, 2018
Closed
@omarreiss omarreiss merged commit fb03f0b into master Aug 6, 2018
@omarreiss omarreiss deleted the try/fix-race-condition-dom-ready branch August 6, 2018 08:46
@gziolo gziolo added the [Package] DOM ready /packages/dom-ready label Aug 6, 2018
@gziolo gziolo added this to the 3.5 milestone Aug 6, 2018
@noisysocks noisysocks mentioned this pull request Aug 7, 2018
Closed
@youknowriad youknowriad mentioned this pull request Aug 7, 2018
Closed
This was referenced Aug 7, 2018
Closed
Closed
Closed
@dependabot-preview dependabot-preview bot mentioned this pull request Feb 4, 2020
Merged
@dependabot-preview dependabot-preview bot mentioned this pull request Apr 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omarreiss omarreiss omarreiss approved these changes

Assignees

@youknowriad youknowriad

Labels
[Package] DOM ready /packages/dom-ready [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
3.5
3 participants
@youknowriad @omarreiss @gziolo