Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing: Remove data-test attribute from UrlInputButton output #7981

Merged
merged 1 commit into from
Jul 16, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Jul 16, 2018

Related: #3550 (comment)

This pull request seeks to update test cases to avoid the need for an attribute output from the UrlInputButton component which is otherwise not referenced or used.

Testing instructions:

Ensure unit tests pass:

npm run test-unit

cc @hideokamoto

@aduth aduth added the [Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests. label Jul 16, 2018
@aduth aduth requested a review from gziolo July 16, 2018 14:35
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this code 👍

@gziolo gziolo added this to the 3.3 milestone Jul 16, 2018
@gziolo gziolo merged commit 15320bf into master Jul 16, 2018
@gziolo gziolo deleted the remove/url-input-button-test-attribute branch July 16, 2018 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Automated Testing Testing infrastructure changes impacting the execution of end-to-end (E2E) and/or unit tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants