Block Edit: Remove legacy context API child context #7869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
[Feature] Rich Text
gziolo
requested changes
Jul 11, 2018
gziolo
reviewed
Jul 11, 2018
|
|
||
| // Hack to avoid the wrapping HoCs. | ||
| import { BlockEdit } from '../../../editor/components/block-edit'; | ||
| import { BlockEdit } from '@wordpress/editor'; |
gziolo
approved these changes
Jul 11, 2018
|
I think I fixed the issue. In my testing, everything works as expected including embedding Google Maps code into HTML block. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to refactor
BlockEditto remove use of the legacy context API (getChildContext).It removes the need for
withSelect, opting instead to omitcanUserUseUnfilteredHTMLfrom block context and consume directly from the single location where it is used (RichText). Presumably this was needed to be passed by context whenRichTextwas not part of the editor directory. ThepostTypeprop, to the best of my knowledge, is not used at all.Testing instructions:
Verify there are no other usage of the
canUserUseUnfilteredHTMLcontext.Ensure there are no regressions in
RichText's use of thecanUserUseUnfilteredHTMLprop (see #4660).