Block List: Reenable pointer events on insertion point hover #7642
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
the
[Feature] Inserter
|
I don't understand how this fixes it, but if it does, holy guacamole is it prettier. I can't test now so if you'd like this in fast, feel free to expand the review range. 🎉 |
jasmussen
approved these changes
Jun 30, 2018
tofumatt
approved these changes
Jun 30, 2018
| @@ -744,6 +744,7 @@ | |||
| opacity: 0; | |||
| pointer-events: none; | |||
|
|
|||
| &:hover, | |||
There was a problem hiding this comment.
I tested this with the keyboard too and it worked, just FYI.
Cool thought, I wish I thought of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #7530
This pull request seeks to resolve the issue with sibling inserter on FIrefox / Safari. The issue was that we make reenable visibility (
opacity) of the insertion point on hover, but there are alsopointer-events: nonewhich were not also being reset on:hover. Not sure why thepointer-eventsare being reset in the first place.Testing instructions:
Repeat testing instructions from #7530