Use withSafeTimeout in NUX tips #7544
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using withSafeTimeout ensures that there is no exception thrown if the component is unexpectedly unmounted. We also make withSafeTimeout use createHigherOrderComponent so that the affected snapshot tests have meaningful component names.
withSafeTimeout gives the component a setTimeout prop, not a setSafeTimeout prop.
noisysocks
added
[Type] Bug
aduth
approved these changes
Jun 26, 2018
Are we sure that this happens? Noting that #7461 ended up being caused by a different issue.
We discussed this a little in #7071. Would love your thoughts there—feel free to re-open the issue 🙂 |
|
Merging this even though it doesn't address #7461 because I reckon it doesn't hurt to be extra safe. |
|
I think #7461 may have had multiple problems combined within the same issue. FWIW, there was a report of failing E2E from the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt at addressing #7461.
There's a chance that the
DotTipcomponent will have unmounted by time thedefercallback executes. We can address this by usingwithSafeTimeout.See #7461 (comment) for some useful context.
How has this been tested?