Inner Blocks: Refactor treatment of block settings #7418
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request seeks to apply a few refactorings to the
InnerBlocks
treatment of its nested settings, namely:componentWillReceiveProps
to equivalentcomponentDidUpdate
(per suggestion at Block List: Remove createInnerBlockList utility / context #7192 (comment))allowedBlocks
prop shapeUPDATE_BLOCK_LIST_SETTINGS
is not passed anid
(was never tested anyways)blockListSettings
whensettings
not set, but theid
never existed in state anyways (including new test)updateIsRequired
condition would be false, which could have introduced future maintainability issues if additionalcase
statements were addedallowedBlocks
(previously also referred to assupportedBlocks
)Testing instructions:
Repeat testing instructions from #6546.